linux-kernel - Re: [PATCH v3 3/3] pwm: hibvt: Add hi3559v100 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190221195641.hqvjxixhj7fi4gff@pengutronix.de>
Date:   Thu, 21 Feb 2019 20:56:41 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Mathieu Othacehe <m.othacehe@...il.com>
Cc:     thierry.reding@...il.com, robh+dt@...nel.org, mark.rutland@....com,
        linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] pwm: hibvt: Add hi3559v100 support

On Tue, Feb 19, 2019 at 10:58:08AM +0100, Mathieu Othacehe wrote:
> Add support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm
> platforms. They require a special quirk: pwm has to be enabled again
> to force duty_cycle refresh.

The patch looks fine now. (If you have to do another round:
s/again/twice/ in the commit log and s/once more/twice/ in the comment
below.)

I wonder if this behaviour is a bug or a feature of the hardware. Is
this additional enable needed to apply changes to both period and
duty_cycle atomically? Is the 2nd enable needed independent of the PWM
already running? Can you share the relevant part of the documentation
without violating an NDA?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |