linux-kernel - Re: [PATCH][RESEND] Make ARM_TIMER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf0a7334-c347-b254-f80d-93640f201b20@linaro.org>
Date:   Thu, 21 Feb 2019 21:48:17 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     David Abdurachmanov <david.abdurachmanov@...il.com>,
        tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][RESEND] Make ARM_TIMER_SP804 depend on (ARM || ARM64)

On 21/02/2019 17:06, David Abdurachmanov wrote:
> Resending to incl. a proper mailing list and maintainers (not suggested
> by scripts/get_maintainer.pl)
> 
> This is only used on arm and arm64 platforms. Other timers also seem
> to depend on (ARM || ARM64).
> 
> After I moved Fedora/RISCV kernel to 5.0.0-0.rc2 it keeps asking me to
> add CONFIG_ARM_TIMER_SP804=n to my config. This patch resolved the issue.
> 
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@...il.com>
> ---
>  drivers/clocksource/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index a9e26f6a81a1..7593d80e1c88 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -369,7 +369,7 @@ config ARM_GLOBAL_TIMER
>  
>  config ARM_TIMER_SP804
>  	bool "Support for Dual Timer SP804 module"
> -	depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
> +	depends on (ARM || ARM64) && GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP

What about adding the COMPILE_TEST option:

bool "Support for Dual Timer SP804 module" if COMPILE_TEST

but not add the ARM || ARM64 dependency ?

>  	select CLKSRC_MMIO
>  	select TIMER_OF if OF
>  
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog