linux-kernel - Re: [PATCH] IB/hfi1: Add missing break in switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c23934c8-94ed-e93c-9fe4-54eeed1586c4@embeddedor.com>
Date:   Thu, 21 Feb 2019 15:26:22 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     Kaike Wan <kaike.wan@...el.com>,
        Mike Marciniszyn <mike.marciniszyn@...el.com>,
        Dennis Dalessandro <dennis.dalessandro@...el.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] IB/hfi1: Add missing break in switch statement



On 2/21/19 3:09 PM, Jason Gunthorpe wrote:
> On Wed, Feb 20, 2019 at 07:02:33PM -0600, Gustavo A. R. Silva wrote:
>> Fix the following warning by adding a missing break:
>>
>> drivers/infiniband/hw/hfi1/tid_rdma.c: In function ‘hfi1_tid_rdma_wqe_interlock’:
>> drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    switch (prev->wr.opcode) {
>>    ^~~~~~
>> drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here
>>   case IB_WR_RDMA_READ:
>>   ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> Reviewed-by: Kaike Wan <Kaike.wan@...el.com>
>> --
>>  drivers/infiniband/hw/hfi1/tid_rdma.c | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Applied to for-next, thanks
> 

Great. :)

Thank you both, Kaike and Jason.

--
Gustavo