linux-kernel - Re: [PATCH 15/20] NFS: drop useless LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81b0b3c72ebb7fc97c3166d945f82ee4184ed657.camel@hammerspace.com>
Date:   Thu, 21 Feb 2019 22:40:52 +0000
From:   Trond Myklebust <trondmy@...merspace.com>
To:     "Julia.Lawall@...6.fr" <Julia.Lawall@...6.fr>
CC:     "anna.schumaker@...app.com" <anna.schumaker@...app.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 15/20] NFS: drop useless LIST_HEAD

On Sun, 2018-12-23 at 09:57 +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares has never
> been used.
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
>   ... when != x
> // </smpl>
> 
> Fixes: 0e20162ed1e9 ("NFSv4.1 Use MDS auth flavor for data server
> connection")
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
> Successfully 0-day tested on 151 configurations.
> 
>  fs/nfs/nfs4client.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c
> index 2548405da1f7..735c1056a91c 100644
> --- a/fs/nfs/nfs4client.c
> +++ b/fs/nfs/nfs4client.c
> @@ -145,7 +145,6 @@ static void
>  nfs4_shutdown_ds_clients(struct nfs_client *clp)
>  {
>  	struct nfs4_ds_server *dss;
> -	LIST_HEAD(shutdown_list);
>  
>  	while (!list_empty(&clp->cl_ds_clients)) {
>  		dss = list_entry(clp->cl_ds_clients.next,
> 

Thanks Julia! Applied to my linux-next branch for inclusion in the 5.1
merge window.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@...merspace.com