linux-kernel - Re: [PATCH 15/17] perf bpf-event: Add missing new line into pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1883F478-13FB-49E8-A062-997678D94860@fb.com>
Date:   Thu, 21 Feb 2019 07:12:13 +0000
From:   Song Liu <songliubraving@...com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Clark Williams <williams@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        "Arnaldo Carvalho de Melo" <acme@...hat.com>
Subject: Re: [PATCH 15/17] perf bpf-event: Add missing new line into pr_debug
 call



> On Feb 20, 2019, at 5:25 PM, Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> 
> From: Jiri Olsa <jolsa@...nel.org>
> 
> Add a missing new line into pr_debug call in perf_event__synthesize_bpf_events(),
> so that the error message does not screw the verbose output.
> 
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Song Liu <songliubraving@...com>
> Link: http://lkml.kernel.org/r/20190220122800.864-5-jolsa@kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Acked-by: Song Liu <songliubraving@...com>

Thanks for fixing this.

Song

> ---
> tools/perf/util/bpf-event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/bpf-event.c b/tools/perf/util/bpf-event.c
> index 62dda96b0096..028c8ec1f62a 100644
> --- a/tools/perf/util/bpf-event.c
> +++ b/tools/perf/util/bpf-event.c
> @@ -233,7 +233,7 @@ int perf_event__synthesize_bpf_events(struct perf_tool *tool,
> 				err = 0;
> 				break;
> 			}
> -			pr_debug("%s: can't get next program: %s%s",
> +			pr_debug("%s: can't get next program: %s%s\n",
> 				 __func__, strerror(errno),
> 				 errno == EINVAL ? " -- kernel too old?" : "");
> 			/* don't report error on old kernel or EPERM  */
> -- 
> 2.19.1
>