linux-kernel - Re: [PATCH 4/4] misc: hpilo: Update driver version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190221083256.GA6397@kroah.com>
Date:   Thu, 21 Feb 2019 09:32:56 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Matt Hsiao <matt.hsiao@....com>
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de,
        david.altobelli@....com, mark.rusk@....com, jerry.hoemann@....com
Subject: Re: [PATCH 4/4] misc: hpilo: Update driver version

On Thu, Feb 21, 2019 at 04:04:42PM +0800, Matt Hsiao wrote:
> Bump version number to reflect recent minor changes.
> 
> Signed-off-by: Matt Hsiao <matt.hsiao@....com>
> ---
>  drivers/misc/hpilo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c
> index 927309b..4ef6802 100644
> --- a/drivers/misc/hpilo.c
> +++ b/drivers/misc/hpilo.c
> @@ -913,7 +913,7 @@ static void __exit ilo_exit(void)
>  	class_destroy(ilo_class);
>  }
>  
> -MODULE_VERSION("1.5.0");
> +MODULE_VERSION("1.5.1");

This line means nothing, it should just be removed entirely.  The
"version" of the driver is the kernel version itself.

Want me to drop it?

thanks,

greg k-h