linux-kernel - Re: [PATCH] printk: Pass caller information to log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190221093242.bhilzd6z54wukx4q@pathway.suse.cz>
Date:   Thu, 21 Feb 2019 10:32:42 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk: Pass caller information to log_store().

On Thu 2019-02-21 11:22:57, Sergey Senozhatsky wrote:
> On (02/16/19 19:59), Tetsuo Handa wrote:
> >  /* insert record into the buffer, discard old ones, update heads */
> > -static int log_store(int facility, int level,
> > +static int log_store(u32 caller_id, int facility, int level,
> >  		     enum log_flags flags, u64 ts_nsec,
> >  		     const char *dict, u16 dict_len,
> >  		     const char *text, u16 text_len)
> 
> I counted nine.
> 
> Dunno, we might want to just create a dummy struct and pass it
> around, instead of doing
> 
> 	vprintk_emit			(6 params)
> 	 vprintk_store			(6 params)
> 	  log_output			(7 params)
> 	   log_store			(9 params)

Yeah, it would make sense. I still dream about a bigger printk
code clean up. But let's see what comes from the realtime-related
patchset first.

Anyway, thanks for review.

Best Regards,
Petr