linux-kernel - Re: [PATCH 0/2] mmc: mmci: add quirk property to add stm32 transfer mode

Open Source and information security mailing list archives

Message-ID: <20190221102739.cc37au6elqu6gvfe@shell.armlinux.org.uk>
Date:   Thu, 21 Feb 2019 10:27:39 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Ludovic Barre <ludovic.Barre@...com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Alexandre Torgue <alexandre.torgue@...com>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        srinivas.kandagatla@...aro.org,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/2] mmc: mmci: add quirk property to add stm32 transfer
 mode

On Thu, Feb 21, 2019 at 11:10:49AM +0100, Ludovic Barre wrote:
> From: Ludovic Barre <ludovic.barre@...com>
> 
> This patch series introduces a bitmap of hardware quirks that require
> some special action. This should reduce the number of boolean
> into variant structure. 
> And adds quirk bit to define sdmmc specific transfer modes.

Please find some other way to deal with these differences.  As far as
I'm concerned, introducing a quirk bitmask such as what was done in
sdhci is a complete disaster and leads to long-term maintanability
problems.

We already have a way to deal with variants in mmci.

> 
> Ludovic Barre (2):
>   mmc: mmci: introduce a quirks property into variant struct
>   mmc: mmci: add quirk property to add stm32 transfer mode
> 
>  drivers/mmc/host/mmci.c | 11 +++++++++++
>  drivers/mmc/host/mmci.h |  9 +++++++++
>  2 files changed, 20 insertions(+)
> 
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives