linux-kernel - Re: [PATCH 1/2] loop: do not print warn message if partition scan is successful

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190221110151.GE27474@quack2.suse.cz>
Date:   Thu, 21 Feb 2019 12:01:51 +0100
From:   Jan Kara <jack@...e.cz>
To:     Dongli Zhang <dongli.zhang@...cle.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        axboe@...nel.dk, jack@...e.cz
Subject: Re: [PATCH 1/2] loop: do not print warn message if partition scan is
 successful

On Thu 21-02-19 12:17:34, Dongli Zhang wrote:
> Do not print warn message when the partition scan returns 0.
> 
> Fixes: d57f3374ba48 ("loop: Move special partition reread handling in loop_clr_fd()")
> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>

Yeah, thanks for the fix! Not sure how come I didn't see this in my
testing. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  drivers/block/loop.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index cf55389..7908673 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1115,8 +1115,9 @@ static int __loop_clr_fd(struct loop_device *lo, bool release)
>  			err = __blkdev_reread_part(bdev);
>  		else
>  			err = blkdev_reread_part(bdev);
> -		pr_warn("%s: partition scan of loop%d failed (rc=%d)\n",
> -			__func__, lo_number, err);
> +		if (err)
> +			pr_warn("%s: partition scan of loop%d failed (rc=%d)\n",
> +				__func__, lo_number, err);
>  		/* Device is gone, no point in returning error */
>  		err = 0;
>  	}
> -- 
> 2.7.4
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR