linux-kernel - Re: [PATCH v5 06/10] Platform: OLPC: Add XO-1.75 EC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcWMf086oGrJHWOCgYFy-J-KLw+jzFoAwuXaHtS7dgdvA@mail.gmail.com>
Date:   Thu, 21 Feb 2019 15:28:26 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Darren Hart <dvhart@...radead.org>
Cc:     Lubomir Rintel <lkundrak@...sk>,
        Andy Shevchenko <andy@...radead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Mark Rutland <mark.rutland@....com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 06/10] Platform: OLPC: Add XO-1.75 EC driver

On Thu, Feb 21, 2019 at 3:22 AM Darren Hart <dvhart@...radead.org> wrote:
>
> On Thu, Jan 10, 2019 at 06:58:41PM +0100, Lubomir Rintel wrote:
> > It's based off the driver from the OLPC kernel sources. Somewhat
> > modernized and cleaned up, for better or worse.
> >
> > Modified to plug into the olpc-ec driver infrastructure (so that battery
> > interface and debugfs could be reused) and the SPI slave framework.

> > Basically all of the above is based on the review by Andy Shevchenko.
>
> Andy, I am happy to merge this series - but this patch includes a lot of changes
> driven by your feedback. Are you satisfied with the changes, would you like to
> add your Reviewed-by?

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Open minors:
 - u8 vs. unsigned char in a cases when it's about command to send to
HW (including unnecessary & 0xff parts)
 - _TIMEOUT w/o units a bit odd (perhaps _TIMEOUT_MS ?)

I think this may be addressed later on.

-- 
With Best Regards,
Andy Shevchenko