linux-kernel - RE: [PATCH] IB/hfi1: Add missing break in switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3F128C9216C9B84BB6ED23EF16290AFB750DB973@CRSMSX101.amr.corp.intel.com>
Date:   Thu, 21 Feb 2019 13:47:28 +0000
From:   "Wan, Kaike" <kaike.wan@...el.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        "Marciniszyn, Mike" <mike.marciniszyn@...el.com>,
        "Dalessandro, Dennis" <dennis.dalessandro@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        "Jason Gunthorpe" <jgg@...pe.ca>
CC:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>
Subject: RE: [PATCH] IB/hfi1: Add missing break in switch statement



> -----Original Message-----
> From: Gustavo A. R. Silva [mailto:gustavo@...eddedor.com]
> Sent: Wednesday, February 20, 2019 8:03 PM
> To: Wan, Kaike <kaike.wan@...el.com>; Marciniszyn, Mike
> <mike.marciniszyn@...el.com>; Dalessandro, Dennis
> <dennis.dalessandro@...el.com>; Doug Ledford <dledford@...hat.com>;
> Jason Gunthorpe <jgg@...pe.ca>
> Cc: linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org; Gustavo A. R.
> Silva <gustavo@...eddedor.com>; Kees Cook <keescook@...omium.org>
> Subject: [PATCH] IB/hfi1: Add missing break in switch statement
> 
> Fix the following warning by adding a missing break:
> 
> drivers/infiniband/hw/hfi1/tid_rdma.c: In function
> ‘hfi1_tid_rdma_wqe_interlock’:
> drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may
> fall through [-Wimplicit-fallthrough=]
>    switch (prev->wr.opcode) {
>    ^~~~~~
> drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here
>   case IB_WR_RDMA_READ:
>   ^~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
> 
> Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and
> other requests")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/infiniband/hw/hfi1/tid_rdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c
> b/drivers/infiniband/hw/hfi1/tid_rdma.c
> index bc2ff83026f7..fdda33aca77f 100644
> --- a/drivers/infiniband/hw/hfi1/tid_rdma.c
> +++ b/drivers/infiniband/hw/hfi1/tid_rdma.c
> @@ -3256,6 +3256,7 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp
> *qp, struct rvt_swqe *wqe)
>  		default:
>  			break;
>  		}
> +		break;
>  	case IB_WR_RDMA_READ:
>  		if (prev->wr.opcode != IB_WR_TID_RDMA_WRITE)
>  			break;
> --

Reviewed-by: Kaike Wan <Kaike.wan@...el.com>

> 2.20.1