linux-kernel - Re: [GIT PULL 5/7] intel_th: Don't reference unassigned outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190221144159.GA9283@kroah.com>
Date:   Thu, 21 Feb 2019 15:41:59 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        linux-kernel@...r.kernel.org, Ammy Yi <ammy.yi@...el.com>
Subject: Re: [GIT PULL 5/7] intel_th: Don't reference unassigned outputs

On Thu, Feb 21, 2019 at 03:49:57PM +0200, Alexander Shishkin wrote:
> When an output port driver is removed, also remove references to it from
> any masters. Failing to do this causes a NULL ptr dereference when
> configuring another output port:
> 
> > BUG: unable to handle kernel NULL pointer dereference at 000000000000000d
> > RIP: 0010:master_attr_store+0x9d/0x160 [intel_th_gth]
> > Call Trace:
> > dev_attr_store+0x1b/0x30
> > sysfs_kf_write+0x3c/0x50
> > kernfs_fop_write+0x125/0x1a0
> > __vfs_write+0x3a/0x190
> > ? __vfs_write+0x5/0x190
> > ? _cond_resched+0x1a/0x50
> > ? rcu_all_qs+0x5/0xb0
> > ? __vfs_write+0x5/0x190
> > vfs_write+0xb8/0x1b0
> > ksys_write+0x55/0xc0
> > __x64_sys_write+0x1a/0x20
> > do_syscall_64+0x5a/0x140
> > entry_SYSCALL_64_after_hwframe+0x44/0xa9
> 
> Signed-off-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Reported-by: Ammy Yi <ammy.yi@...el.com>
> ---
>  drivers/hwtracing/intel_th/gth.c | 4 ++++
>  1 file changed, 4 insertions(+)

Shouldn't this have a cc: stable?

And what commit does this "fix"?

thanks,

greg k-h