linux-kernel - Re: [PATCH v11] dm: add support to directly boot to a mapped device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKiEmmpVE0f_9r4Wop8c11skcsgAruGr2UbOiAof8T7DA@mail.gmail.com>
Date:   Thu, 21 Feb 2019 09:13:34 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Mike Snitzer <snitzer@...hat.com>
Cc:     Helen Koike <helen.koike@...labora.com>,
        device-mapper development <dm-devel@...hat.com>,
        Will Drewry <wad@...omium.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        richard -rw- weinberger <richard.weinberger@...il.com>,
        LKML <linux-kernel@...r.kernel.org>, linux-lvm@...hat.com,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        kernel@...labora.com, Alasdair G Kergon <agk@...hat.com>,
        David Zeuthen <zeuthen@...gle.com>
Subject: Re: [PATCH v11] dm: add support to directly boot to a mapped device

On Thu, Feb 21, 2019 at 7:50 AM Mike Snitzer <snitzer@...hat.com> wrote:
>
> On Mon, Feb 18 2019 at  1:18pm -0500,
> Helen Koike <helen.koike@...labora.com> wrote:
>
> > Add a dm-mod.create= kernel module parameter.
> > It allows device-mapper targets to be configured at boot time for use early
> > in the boot process (as the root device or otherwise).
> >
> > Signed-off-by: Will Drewry <wad@...omium.org>
> > Signed-off-by: Kees Cook <keescook@...omium.org>
> > [rework to use dm_ioctl calls]
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > [refactored for upstream]
> > Signed-off-by: Helen Koike <helen.koike@...labora.com>
>
> Can I get confirmation from Will and Kees that this v11 is safe to carry
> their Signed-off-by?  Are you guys "happy" with this patch?

I think those should be "Co-developed-by:" to more correctly capture
the intent. At this point I think Helen is the primary author. Or at
least, Will and I aren't anymore. :)

At first pass, yes, this patch does what's needed for Chrome OS and
Android, but I'll take a closer look shortly (and I've added David who
has looked at this most recently).

Thanks!

-- 
Kees Cook