linux-kernel - RE: [PATCH] soc: fsl: guts: make fsl_guts_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0401MB2237C56CD38D546E83218C8FF87F0@VI1PR0401MB2237.eurprd04.prod.outlook.com>
Date:   Fri, 22 Feb 2019 08:07:32 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     Horia Geanta <horia.geanta@....com>, Leo Li <leoyang.li@....com>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] soc: fsl: guts: make fsl_guts_get_svr() static



> -----Original Message-----
> From: Horia Geantă <horia.geanta@....com>
> Sent: Thursday, February 21, 2019 6:38 PM
> To: Leo Li <leoyang.li@....com>
> Cc: Y.b. Lu <yangbo.lu@....com>; linuxppc-dev@...ts.ozlabs.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] soc: fsl: guts: make fsl_guts_get_svr() static
> 
> The export of fsl_guts_get_svr() is a left-over, it's currently used only internally
> and users needing SoC information should use the generic soc_device
> infrastructure.
> 

[Y.b. Lu] Acked-by: Yangbo Lu <yangbo.lu@....com>

> Signed-off-by: Horia Geantă <horia.geanta@....com>
> ---
>  drivers/soc/fsl/guts.c   | 3 +--
>  include/linux/fsl/guts.h | 2 --
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index
> 4f9655087bd7..63f6df86f9e5 100644
> --- a/drivers/soc/fsl/guts.c
> +++ b/drivers/soc/fsl/guts.c
> @@ -115,7 +115,7 @@ static const struct fsl_soc_die_attr
> *fsl_soc_die_match(
>  	return NULL;
>  }
> 
> -u32 fsl_guts_get_svr(void)
> +static u32 fsl_guts_get_svr(void)
>  {
>  	u32 svr = 0;
> 
> @@ -129,7 +129,6 @@ u32 fsl_guts_get_svr(void)
> 
>  	return svr;
>  }
> -EXPORT_SYMBOL(fsl_guts_get_svr);
> 
>  static int fsl_guts_probe(struct platform_device *pdev)  { diff --git
> a/include/linux/fsl/guts.h b/include/linux/fsl/guts.h index
> 941b11811f85..1fc0edd71c52 100644
> --- a/include/linux/fsl/guts.h
> +++ b/include/linux/fsl/guts.h
> @@ -135,8 +135,6 @@ struct ccsr_guts {
>  	u32	srds2cr1;	/* 0x.0f44 - SerDes2 Control Register 0 */
>  } __attribute__ ((packed));
> 
> -u32 fsl_guts_get_svr(void);
> -
>  /* Alternate function signal multiplex control */  #define
> MPC85xx_PMUXCR_QE(x) (0x8000 >> (x))
> 
> --
> 2.16.2