linux-kernel - Re: [PATCH] regulator: max77650: Fix set_current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJXTX7RcBqXziFuvmUvZWyWfBaRYmoEORm48mhbF-HN5ZQ@mail.gmail.com>
Date:   Fri, 22 Feb 2019 10:16:34 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Axel Lin <axel.lin@...ics.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: max77650: Fix set_current_limit implementation

pt., 22 lut 2019 o 10:09 Axel Lin <axel.lin@...ics.com> napisał(a):
>
> Current code always return error, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/regulator/max77650-regulator.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/regulator/max77650-regulator.c b/drivers/regulator/max77650-regulator.c
> index 411912d5278b..a1af414db751 100644
> --- a/drivers/regulator/max77650-regulator.c
> +++ b/drivers/regulator/max77650-regulator.c
> @@ -243,7 +243,7 @@ static int max77650_regulator_set_current_limit(struct regulator_dev *rdev,
>  {
>         struct max77650_regulator_desc *rdesc;
>         struct regmap *map;
> -       int rv, i, limit;
> +       int i, limit;
>
>         rdesc = rdev_get_drvdata(rdev);
>         map = rdev_get_regmap(rdev);
> @@ -252,11 +252,9 @@ static int max77650_regulator_set_current_limit(struct regulator_dev *rdev,
>                 limit = max77650_current_limit_table[i];
>
>                 if (limit >= min_uA && limit <= max_uA) {
> -                       rv = regmap_update_bits(map, rdesc->regA,
> +                       return regmap_update_bits(map, rdesc->regA,
>                                         MAX77650_REGULATOR_CURR_LIM_MASK,
>                                         MAX77650_REGULATOR_CURR_LIM_SHIFT(i));
> -                       if (rv)
> -                               return rv;
>                 }
>         }
>
> --
> 2.17.1
>

Thanks for spotting that!

Reviewed-by: Bartosz Golaszewski <bgolaszewski@...libre.com>