linux-kernel - Re: powerpc/powernv/npu: Remove redundant change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <445RN24dKKz9sB3@ozlabs.org>
Date:   Fri, 22 Feb 2019 20:47:46 +1100 (AEDT)
From:   Michael Ellerman <patch-notifications@...erman.id.au>
To:     Peter Xu <peterx@...hat.com>, linux-kernel@...r.kernel.org
Cc:     Andrea Arcangeli <aarcange@...hat.com>,
        Alexey Kardashevskiy <aik@...abs.ru>,
        Mark Hairgrove <mhairgrove@...dia.com>, peterx@...hat.com,
        Jerome Glisse <jglisse@...hat.com>,
        Paul Mackerras <paulus@...ba.org>,
        Alistair Popple <alistair@...ple.id.au>,
        linuxppc-dev@...ts.ozlabs.org, Jason Wang <jasowang@...hat.com>,
        David Gibson <david@...son.dropbear.id.au>
Subject: Re: powerpc/powernv/npu: Remove redundant change_pte() hook

On Thu, 2019-01-31 at 10:30:22 UTC, Peter Xu wrote:
> The change_pte() notifier was designed to use as a quick path to
> update secondary MMU PTEs on write permission changes or PFN changes.
> For KVM, it could reduce the vm-exits when vcpu faults on the pages
> that was touched up by KSM.  It's not used to do cache invalidations,
> for example, if we see the notifier will be called before the real PTE
> update after all (please see set_pte_at_notify that set_pte_at was
> called later).
> 
> All the necessary cache invalidation should all be done in
> invalidate_range() already.
> 
> CC: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> CC: Paul Mackerras <paulus@...ba.org>
> CC: Michael Ellerman <mpe@...erman.id.au>
> CC: Alistair Popple <alistair@...ple.id.au>
> CC: Alexey Kardashevskiy <aik@...abs.ru>
> CC: Mark Hairgrove <mhairgrove@...dia.com>
> CC: Balbir Singh <bsingharora@...il.com>
> CC: David Gibson <david@...son.dropbear.id.au>
> CC: Andrea Arcangeli <aarcange@...hat.com>
> CC: Jerome Glisse <jglisse@...hat.com>
> CC: Jason Wang <jasowang@...hat.com>
> CC: linuxppc-dev@...ts.ozlabs.org
> CC: linux-kernel@...r.kernel.org
> Signed-off-by: Peter Xu <peterx@...hat.com>
> Reviewed-by: Andrea Arcangeli <aarcange@...hat.com>
> Reviewed-by: Alistair Popple <alistair@...ple.id.au>
> Reviewed-by: Balbir Singh <bsingharora@...il.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/1b58a975be36994a572ae3b3fb3e0232

cheers