linux-kernel - Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ac9ee8e-cd7a-10e4-e176-428344e980a6@infradead.org>
Date:   Fri, 22 Feb 2019 08:50:24 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Nick Crews <ncrews@...omium.org>, bleung@...omium.org
Cc:     linux-kernel@...r.kernel.org, dlaurie@...omium.org,
        sfr@...b.auug.org.au
Subject: Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for
 wilco_ec

On 2/20/19 11:57 PM, Enric Balletbo i Serra wrote:
> Hi,
> 
> On 21/2/19 0:09, Randy Dunlap wrote:
>> On 2/20/19 2:11 PM, Nick Crews wrote:
>>> In the initial version of the Wilco EC Driver, the
>>> dependency order was wrong. It before was possible to
>>> select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without
>>> having CONFIG_CROS_EC_LPC_MEC. This was wrong, since
>>> WILCO_EC depends upon CONFIG CROS_EC_LPC_MEC, not the
>>> other way around.
>>>
>>> Fixes: 1733c32834e5d1 ("platform/chrome: Add new driver for Wilco EC")
>>> Signed-off-by: Nick Crews <ncrews@...omium.org>
>>
>> Reported-by: Randy Dunlap <rdunlap@...radead.org>
>> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested
>>
> 
> As this is [-next] material I squashed that commit and queued for 5.1

Hi,

on linux-next of 20190222, I now see this build error + Kconfig warnings:

(this is on i386; randconfig file is attached)

WARNING: unmet direct dependencies detected for SND_SOC_CROS_EC_CODEC
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && MFD_CROS_EC [=n]
  Selected by [y]:
  - SND_SOC_SDM845 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && QCOM_APR [=y]

ld: sound/soc/codecs/cros_ec_codec.o: in function `ec_command_no_resp':
cros_ec_codec.c:(.text+0x50): undefined reference to `cros_ec_cmd_xfer_status'
ld: sound/soc/codecs/cros_ec_codec.o: in function `mic_gain_get':
cros_ec_codec.c:(.text+0x5a8): undefined reference to `cros_ec_cmd_xfer_status'



-- 
~Randy

View attachment "config-r4148" of type "text/plain" (106063 bytes)