linux-kernel - Re: [PATCH v7 00/23] locking/lockdep: Add support for dynamic keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7216ba17-8e38-d8e9-6ba3-1bc0e6a9fc2d@acm.org>
Date:   Fri, 22 Feb 2019 09:20:34 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     mingo@...hat.com, will.deacon@....com, tj@...nel.org,
        longman@...hat.com, johannes.berg@...el.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 00/23] locking/lockdep: Add support for dynamic keys

On 2/22/19 8:26 AM, Peter Zijlstra wrote:
> I've gone over all and I think it looks ok now; I'll give it another
> round tomorrow^Wmonday and then queue bits.
> 
> So far the only changes I've made are the below. I'm not entirely sure
> on the unconditional validity check on DEBUG_LOCKDEP, maybe I'll add a
> boot param for that.

Hi Peter,

Please keep in mind that calling check_data_structures() slows down the 
kernel a lot and also that it makes systems much less responsive. This 
is because the consistency checks disable interrupts for a long time, up 
to several seconds. That is why I think it should be possible to enable 
and disable the consistency checks independent of other kernel config 
options.

Thanks,

Bart.