linux-kernel - Re: [PATCH V4 1/4] dt-binding: irq: imx-irqsteer: use irq number instead of group number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190222173738.GA2168@bogus>
Date:   Fri, 22 Feb 2019 11:37:38 -0600
From:   Rob Herring <robh@...nel.org>
To:     Aisheng Dong <aisheng.dong@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Aisheng Dong <aisheng.dong@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Marc Zyngier <marc.zyngier@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        dl-linux-imx <linux-imx@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>
Subject: Re: [PATCH V4 1/4] dt-binding: irq: imx-irqsteer: use irq number
 instead  of group number

On Wed, 20 Feb 2019 11:40:40 +0000, Aisheng Dong wrote:
> Not all 64 interrupts may be used in one group. e.g. most irqsteer in
> imx8qxp and imx8qm subsystems supports only 32 interrupts.
> 
> As the IP integration parameters are Channel number and interrupts number,
> let's use fsl,irqs-num to represents how many interrupts supported
> by this irqsteer channel.
> 
> Note this will break the compatibility of old binding. As the original
> fsl,irq-groups was born out of a misunderstanding of the HW config
> options and we are not aware of any users of the current binding.
> And the old binding was just published in recent months, so it's
> worth to change now to avoid confusing in the future.
> 
> Cc: Marc Zyngier <marc.zyngier@....com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Shawn Guo <shawnguo@...nel.org>
> Cc: devicetree@...r.kernel.org
> Reviewed-by: Lucas Stach <l.stach@...gutronix.de>
> Signed-off-by: Dong Aisheng <aisheng.dong@....com>
> ---
> ChangeLog:
> v3->v4:
>  * add more commit messages to describe the compatibility break
> v2->v3:
>  * no changes
> v1->v2:
>  * change property name fsl,irqs-per-chan to fsl,num-irqs.
> ---
>  .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt       | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>