linux-kernel - Re: [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aedb3a7e-058e-ec62-93c7-0767717b9ea9@kernel.org>
Date:   Fri, 22 Feb 2019 15:46:03 -0700
From:   shuah <shuah@...nel.org>
To:     Juerg Haefliger <juerg.haefliger@...onical.com>,
        linux-kernel@...r.kernel.org, rostedt@...dmis.org,
        mingo@...hat.com, mhiramat@...nel.org,
        linux-kselftest@...r.kernel.org
Cc:     Juerg Haefliger <juergh@...onical.com>, shuah <shuah@...nel.org>
Subject: Re: [RESEND PATCH v2 2/2] selftests/ftrace: Replace \e with \033

On 2/22/19 1:53 PM, Juerg Haefliger wrote:
> The \e sequence character is not POSIX. Fix that by using \033 instead.
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> Acked-by: Masami Hiramatsu <mhiramat@...nel.org>
> Signed-off-by: Juerg Haefliger <juergh@...onical.com>
> ---
>   tools/testing/selftests/ftrace/ftracetest | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> index 20c9c0ad8682..136387422b00 100755
> --- a/tools/testing/selftests/ftrace/ftracetest
> +++ b/tools/testing/selftests/ftrace/ftracetest
> @@ -161,10 +161,10 @@ color_green=
>   color_blue=
>   # If stdout exists and number of colors is eight or more, use them
>   if [ -t 1 -a "$ncolors" -ge 8 ]; then
> -  color_reset="\e[0m"
> -  color_red="\e[31m"
> -  color_green="\e[32m"
> -  color_blue="\e[34m"
> +  color_reset="\033[0m"
> +  color_red="\033[31m"
> +  color_green="\033[32m"
> +  color_blue="\033[34m"
>   fi
>   
>   strip_esc() {
> 

Which release is this patch based on?

This one failed to apply to linux-kselftest next - I resolved a minor
merge conflict and applied it. Please review to make sure it looks good.

thanks,
-- Shuah