linux-kernel - Re: [GIT PULL v3] Hyper-V commits for 5.0-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190223085715.GA22149@kroah.com>
Date:   Sat, 23 Feb 2019 09:57:15 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...rosoft.com, linux-hyperv@...r.kernel.org,
        kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL v3] Hyper-V commits for 5.0-rc

On Fri, Feb 22, 2019 at 10:12:25PM -0500, Sasha Levin wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> The following changes since commit 8834f5600cf3c8db365e18a3d5cac2c2780c81e5:
> 
>   Linux 5.0-rc5 (2019-02-03 13:48:04 -0800)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git tags/hyperv-fixes-signed
> 
> for you to fetch changes up to b2946cd86f3c1b5b1262c0ec06068110c2328fe6:
> 
>   MAINTAINERS: Change mailing list for Hyper-V CORE AND DRIVERS (2019-02-22 21:46:37 -0500)
> 
> - ----------------------------------------------------------------
> Two fixes:
> 
> 1. A fix for a race condition reading sysfs entries while a device is
> being added, by Kimberly Brown.
> 
> 2. Update the Hyper-V mailing list to a new one created on
> vger.kernel.org, by Haiyang Zhang.
> 
> - ----------------------------------------------------------------
> Haiyang Zhang (1):
>       MAINTAINERS: Change mailing list for Hyper-V CORE AND DRIVERS
> 
> Kimberly Brown (2):
>       Drivers: hv: vmbus: Change server monitor_pages index to 0
>       Drivers: hv: vmbus: Return -EINVAL if monitor_allocated not set

I objected to this last patch when it was posted on the list.  The sysfs
file should just not be present if the functionality is not there, no
need to add the "-EINVAL" logic to it instead.

Having a sysfs file that says it can be read, and then rejecting that
read with an error is NOT ok.

I'll cherry-pick the other two patches, but this one needs to be
reworked.

thanks,

greg k-h