linux-kernel - RE: [PATCH] usb: dwc3: gadget: issue a stop command for ISOC endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <678F3D1BB717D949B966B68EAEB446ED24E7D8F2@dggemm526-mbx.china.huawei.com>
Date:   Sat, 23 Feb 2019 09:26:05 +0000
From:   "Zengtao (B)" <prime.zeng@...ilicon.com>
To:     Felipe Balbi <felipe.balbi@...ux.intel.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Laurent Pinchart" <laurent.pinchart@...asonboard.com>
Subject: RE: [PATCH] usb: dwc3: gadget: issue a stop command for ISOC
 endpoint

Hi balbi:

I got this issue in the UVC application, and I think this issue still exist in the 
latest dwc3 driver.

And we should issue an stop command and the queue is empty when it's 
ISOC transfer, otherwise we will end up with MISS ISOC error for all the 
upcoming transfers.

So I think you can test the UVC application with the latest driver.

Regards
Zengtao 

>-----Original Message-----
>From: Felipe Balbi [mailto:felipe.balbi@...ux.intel.com]
>Sent: Monday, January 21, 2019 4:56 PM
>To: Zengtao (B) <prime.zeng@...ilicon.com>
>Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>;
>linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Laurent
>Pinchart <laurent.pinchart@...asonboard.com>
>Subject: RE: [PATCH] usb: dwc3: gadget: issue a stop command for ISOC
>endpoint
>
>* PGP Signed by an unknown key
>
>
>Hi,
>
>"Zengtao (B)" <prime.zeng@...ilicon.com> writes:
>>>-----Original Message-----
>>>From: Felipe Balbi [mailto:felipe.balbi@...ux.intel.com]
>>>Sent: Monday, January 21, 2019 4:17 PM
>>>To: Zengtao (B) <prime.zeng@...ilicon.com>
>>>Cc: Zengtao (B) <prime.zeng@...ilicon.com>; Greg Kroah-Hartman
>>><gregkh@...uxfoundation.org>; linux-usb@...r.kernel.org;
>>>linux-kernel@...r.kernel.org
>>>Subject: Re: [PATCH] usb: dwc3: gadget: issue a stop command for
>ISOC
>>>endpoint
>>>
>>>> Old Signed by an unknown key
>>>
>>>
>>>Hi,
>>>
>>>Zeng Tao <prime.zeng@...ilicon.com> writes:
>>>> For ISOC transfers, if there is no available data for a period, we
>>>> need to stop the transfer by issue a stop command, otherwise, all
>>>> the upcoming transfers will started by update transfer command,
>and
>>>> will be dropped with MISS ISOC errors.
>>>
>>>We, actually, have code to handle missed isoc errors now. Have you
>>>tested with that applied? Which kernel are you using? Can you share
>>>tracepoints captured with v5.0-rc3?
>>>
>>
>> Not v5.0-rc3, but I tested it based on 4.9 with backported dwc3
>> driver. And with UVC application, it's very easy to reproduce it.
>
>Ok, so it could be that you missed patches while backporting, right?
>How can I reproduce this? What do I need? Care to give detailed
>instructions?
>
>--
>balbi
>
>* Unknown Key
>* 0xE11A9906