linux-kernel - Re: [PATCH 2/2] habanalabs: driver's Kconfig must select DMA_SHARED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 23 Feb 2019 10:34:07 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Oded Gabbay <oded.gabbay@...il.com>
Cc:     "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH 2/2] habanalabs: driver's Kconfig must select
 DMA_SHARED_BUFFER

On Sat, Feb 23, 2019 at 11:19:07AM +0200, Oded Gabbay wrote:
> On Sat, Feb 23, 2019 at 11:17 AM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Fri, Feb 22, 2019 at 09:29:59PM +0200, Oded Gabbay wrote:
> > > The driver uses the DMA_BUF module which is built only if
> > > DMA_SHARED_BUFFER is selected. DMA_SHARED_BUFFER doesn't have any
> > > dependencies so it is ok to select it (as done by many other components).
> > >
> > > Signed-off-by: Oded Gabbay <oded.gabbay@...il.com>
> >
> > kbuild reported this, right?  You should always add that type of credit
> > to the patch.  I'll go add it by hand this time...
> >
> > thanks,
> >
> > greg k-h
> 
> Ah, I didn't know that, sorry. It wasn't enforced in drm :(

Really?  The drm developers should know better, that's not ok :(