linux-kernel - Re: [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 23 Feb 2019 22:35:11 +0800
From:   Tianyu Lan <lantianyu1986@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Lan Tianyu <Tianyu.Lan@...rosoft.com>, kys@...rosoft.com,
        haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        Sasha Levin <sashal@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, bp@...en8.de,
        "H. Peter Anvin" <hpa@...or.com>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krcmar <rkrcmar@...hat.com>,
        devel@...uxdriverproject.org,
        "linux-kernel@...r kernel org" <linux-kernel@...r.kernel.org>,
        kvm <kvm@...r.kernel.org>, michael.h.kelley@...rosoft.com,
        Vitaly Kuznetsov <vkuznets@...hat.com>, stable@...r.kernel.org
Subject: Re: [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT

On Fri, Feb 22, 2019 at 10:32 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Fri, Feb 22, 2019 at 06:48:44PM +0800, lantianyu1986@...il.com wrote:
> > From: Lan Tianyu <Tianyu.Lan@...rosoft.com>
> >
> > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall
> > is equal with how many entries of union hv_gpa_page_range can be populated
> > into the input parameter page. The origin code lacks parenthesis around
> > PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it.
> >
> > Cc: <stable@...r.kernel.org>
> > Fixs: cc4edae4b9(x86/hyper-v: Add HvFlushGuestAddressList hypercall support)
>
> Please use this format instead:
>
> Fixes: cc4edae4b924 ("x86/hyper-v: Add HvFlushGuestAddressList hypercall support")
>
> And don't type it by hand, use a git alias for it:
>         git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
>

OK. Will update. Thanks.

> You also messed up your To: line, keeping anyone from being able to
> respond to this message who do not know how to hand-edit the response
> line :(

I put all expected reviewers in the Cc line and will put into To line.

>
> thanks,
>
> greg k-h



-- 
Best regards
Tianyu Lan