linux-kernel - Re: [PATCH] au0828: minor fix to a misleading comment in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190223014422.GS11484@bigcity.dyn.berto.se>
Date:   Sat, 23 Feb 2019 02:44:22 +0100
From:   "Niklas Söderlund" <niklas.soderlund@...natech.se>
To:     Shuah Khan <shuah@...nel.org>
Cc:     mchehab@...nel.org, hans.verkuil@...co.com, keescook@...omium.org,
        sakari.ailus@...ux.intel.com, colin.king@...onical.com,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] au0828: minor fix to a misleading comment in _close()

Hi Shuah,

Thanks for your patch.

On 2019-02-22 10:45:59 -0700, Shuah Khan wrote:
> Fix misleading comment in _close()
> 
> Signed-off-by: Shuah Khan <shuah@...nel.org>
> ---
>  drivers/media/usb/au0828/au0828-video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c
> index 7876c897cc1d..08f566006a1f 100644
> --- a/drivers/media/usb/au0828/au0828-video.c
> +++ b/drivers/media/usb/au0828/au0828-video.c
> @@ -1074,7 +1074,7 @@ static int au0828_v4l2_close(struct file *filp)
>  		 * so the s_power callback are silently ignored.
>  		 * So, the current logic here does the following:
>  		 * Disable (put tuner to sleep) when
> -		 * - ALSA and DVB aren't not streaming;
> +		 * - ALSA and DVB aren't streaming;

Nit-picking, as you are modifying the line anyhow I would s/;/./
With or without this changed,

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

>  		 * - the last V4L2 file handler is closed.
>  		 *
>  		 * FIXME:
> -- 
> 2.17.1
> 

-- 
Regards,
Niklas Söderlund