linux-kernel - Re: [PATCH V2] staging: ks7070: removed unused varibales

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMhs-H_7-S-r+ZE_eB8HUr8Z-G=YqugY8rT5YXujUxoXVFT=0A@mail.gmail.com>
Date:   Sat, 23 Feb 2019 08:34:42 +0100
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     Bo YU <tsu.yubo@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, quytelda@...alin.org,
        devel@...verdev.osuosl.org,
        linux-kernel <linux-kernel@...r.kernel.org>, yuzibode@....com
Subject: Re: [PATCH V2] staging: ks7070: removed unused varibales

Hi Bo,

On Sat, Feb 23, 2019 at 8:27 AM Bo YU <tsu.yubo@...il.com> wrote:
>
> From: Bo Yu <tsu.yubo@...il.com>
>
> Compiling the kernel with W=1 results in the following warning:
>
> drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’
> set but not used [-Wunused-but-set-variable]
>   u16 mib_val_type;
>
> drivers/staging/ks7010/ks_hostif.c:464:6: warning: variable ‘mib_val_size’
> set but not used [-Wunused-but-set-variable]
>     u16 mib_val_size;
>
> drivers/staging/ks7010/ks_hostif.c:786:6: warning: variable ‘result_code’
> set but not used [-Wunused-but-set-variable]
>       u16 result_code;
>
> Remove these variables.
>
> Rebase on next-20190222
> V2: fix patch format

As Dan has just said, this two rebase and v2 stuff is not needed in
the changelog.
Please, put it under the --- cut off line.

>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Sergio Paracuellos <sergio.paracuellos@...il.com>
> Cc: Quytelda Kahja <quytelda@...alin.org>
>
> Signed-off-by: Bo Yu <tsu.yubo@...il.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index d938b0997a53..913d8996437a 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -461,13 +461,9 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
>         struct net_device *dev = priv->net_dev;
>         u32 mib_status;
>         u32 mib_attribute;
> -       u16 mib_val_size;
> -       u16 mib_val_type;
>
>         mib_status = get_dword(priv);
>         mib_attribute = get_dword(priv);
> -       mib_val_size = get_word(priv);
> -       mib_val_type = get_word(priv);
>
>         if (mib_status) {
>                 netdev_err(priv->net_dev, "attribute=%08X, status=%08X\n",
> @@ -783,9 +779,7 @@ void hostif_ps_adhoc_set_confirm(struct ks_wlan_private *priv)
>  static
>  void hostif_infrastructure_set_confirm(struct ks_wlan_private *priv)
>  {
> -       u16 result_code;
>
> -       result_code = get_word(priv);
>         priv->infra_status = 1; /* infrastructure mode set */
>         hostif_sme_enqueue(priv, SME_MODE_SET_CONFIRM);
>  }
> --
> 2.11.0
>

The commit message is still wrong. The driver name is not called
ks7070 is called ks7010, right? and
also the typo with "varibales" is still wrong... Let's do all changes
right at once, please :)

Best regards,
    Sergio Paracuellos