| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <96932b3e-87f1-d8f2-95bc-0e9a8d5d45ed@roeck-us.net>
Date: Sat, 23 Feb 2019 19:20:21 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Anson Huang <anson.huang@....com>, Rob Herring <robh@...nel.org>
Cc: "mark.rutland@....com" <mark.rutland@....com>,
"shawnguo@...nel.org" <shawnguo@...nel.org>,
"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
"festevam@...il.com" <festevam@...il.com>,
"catalin.marinas@....com" <catalin.marinas@....com>,
"will.deacon@....com" <will.deacon@....com>,
"wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
Aisheng Dong <aisheng.dong@....com>,
"ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
Daniel Baluta <daniel.baluta@....com>,
Andy Gross <andy.gross@...aro.org>,
"horms+renesas@...ge.net.au" <horms+renesas@...ge.net.au>,
"heiko@...ech.de" <heiko@...ech.de>,
"arnd@...db.de" <arnd@...db.de>,
"bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
"jagan@...rulasolutions.com" <jagan@...rulasolutions.com>,
"enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
"marc.w.gonzalez@...e.fr" <marc.w.gonzalez@...e.fr>,
"olof@...om.net" <olof@...om.net>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH RESEND V2 1/4] dt-bindings: fsl: scu: add watchdog binding
On 2/23/19 7:04 PM, Anson Huang wrote:
> Hi, Guenter/Rob
>
> Best Regards!
> Anson Huang
>
>> -----Original Message-----
>> From: Guenter Roeck [mailto:groeck7@...il.com] On Behalf Of Guenter
>> Roeck
>> Sent: 2019年2月24日 1:08
>> To: Rob Herring <robh@...nel.org>; Anson Huang <anson.huang@....com>
>> Cc: mark.rutland@....com; shawnguo@...nel.org;
>> s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com;
>> catalin.marinas@....com; will.deacon@....com; wim@...ux-watchdog.org;
>> Aisheng Dong <aisheng.dong@....com>; ulf.hansson@...aro.org; Daniel
>> Baluta <daniel.baluta@....com>; Andy Gross <andy.gross@...aro.org>;
>> horms+renesas@...ge.net.au; heiko@...ech.de; arnd@...db.de;
>> bjorn.andersson@...aro.org; jagan@...rulasolutions.com;
>> enric.balletbo@...labora.com; marc.w.gonzalez@...e.fr; olof@...om.net;
>> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
>> kernel@...ts.infradead.org; linux-watchdog@...r.kernel.org; dl-linux-imx
>> <linux-imx@....com>
>> Subject: Re: [PATCH RESEND V2 1/4] dt-bindings: fsl: scu: add watchdog
>> binding
>>
>> On 2/22/19 11:52 AM, Rob Herring wrote:
>>> On Mon, Feb 18, 2019 at 06:53:48AM +0000, Anson Huang wrote:
>>>> Add i.MX8QXP system controller watchdog binding.
>>>>
>>>> Signed-off-by: Anson Huang <Anson.Huang@....com>
>>>> ---
>>>> Changes since V1:
>>>> - update dts node name to "watchdog";
>>>> ---
>>>> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 10
>> ++++++++++
>>>> 1 file changed, 10 insertions(+)
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
>>>> b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
>>>> index 4b79751..f388ec6 100644
>>>> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
>>>> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
>>>> @@ -136,6 +136,12 @@ Required properties:
>>>> resource id for thermal driver to get temperature
>> via
>>>> SCU IPC.
>>>>
>>>> +Watchdog bindings based on SCU Message Protocol
>>>> +------------------------------------------------------------
>>>> +
>>>> +Required properties:
>>>> +- compatible: should be "fsl,imx8qxp-sc-wdt";
>>>> +
>>>> Example (imx8qxp):
>>>> -------------
>>>> lsio_mu1: mailbox@...c0000 {
>>>> @@ -188,6 +194,10 @@ firmware {
>>>> tsens-num = <1>;
>>>> #thermal-sensor-cells = <1>;
>>>> };
>>>> +
>>>> + watchdog: watchdog {
>>>> + compatible = "fsl,imx8qxp-sc-wdt";
>>>
>>> As-is, there's no reason for this to be in DT. The parent node's
>>> driver can instantiate the wdog.
>>>
>>
>> As the driver is currently written, you are correct, since it doesn't accept
>> watchdog timeout configuration through devicetree.
>>
>> Question is if that is intended. Is it ?
>
> I am a little confused, do you mean we no need to have "watchdog" node in side "scu"
> node? Or we need to modify the watchdog node's compatible string to " fsl,imx-sc-wdt" to make
> it more generic for other platforms? If yes, I can resend the patch series to modify it.
>
I think Rob suggested that the SCU parent driver should instantiate the watchdog
without explicit watchdog node. That would be possible, but it currently uses
devm_of_platform_populate() to do the instantiation, and changing that would
be a mess. Besides, it does sem to me that your suggested node would describe
the hardware, so I am not sure I understand the reasoning.
For my part I referred to
watchdog_init_timeout(imx_sc_wdd, DEFAULT_TIMEOUT, &pdev->dev);
in the driver, which guarantees that the timeout property will not be used
to set the timeout. A more common implementation would have been
imx_sc_wdd->timeout = DEFAULT_TIMEOUT;
ret = watchdog_init_timeout(imx_sc_wdd, timeout, &pdev->dev);
where 'timeout' is the module parameter. Which is actually not used in your driver.
Hmm ... I wasn't careful enough with my review. The timeout initialization as-is
doesn't make sense. I'll comment on that in the patch.
Guenter
> Anson.
>
>>
>> Thanks,
>> Guenter
Powered by blists - more mailing lists