lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 24 Feb 2019 20:42:07 +0100
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Bharath Vedartham <linux.bhar@...il.com>
Cc:     w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
        gregkh@...uxfoundation.org, speakup@...ux-speakup.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging : speakup: Fix format issues in Kconfig

Bharath Vedartham, le dim. 24 févr. 2019 18:41:42 +0530, a ecrit:
> Fix the checkpatch.pl warning to replace ---help--- with help in
> Kconfig.
> 
> Signed-off-by: Bharath Vedartham <linux.bhar@...il.com>

Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>

Thanks!

> ---
> Changes since v1:
> 	- Allign help and removed redundant spaces.
> ---
>  drivers/staging/speakup/Kconfig | 42 ++++++++++++++++-------------------------
>  1 file changed, 16 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/staging/speakup/Kconfig b/drivers/staging/speakup/Kconfig
> index efd6f45..4a78ab1 100644
> --- a/drivers/staging/speakup/Kconfig
> +++ b/drivers/staging/speakup/Kconfig
> @@ -3,7 +3,7 @@ menu "Speakup console speech"
>  config SPEAKUP
>  	depends on VT
>  	tristate "Speakup core"
> -	---help---
> +	help
>  		This is the Speakup screen reader.  Think of it as a
>  		video console for blind people.  If built in to the
>  		kernel, it can speak everything on the text console from
> @@ -43,7 +43,7 @@ config SPEAKUP
>  if SPEAKUP
>  config SPEAKUP_SYNTH_ACNTSA
>  	tristate "Accent SA synthesizer support"
> -	---help---
> +	help
>  		This is the Speakup driver for the Accent SA
>  		synthesizer.  You can say y to build it into the kernel,
>  		or m to build it as a module.  See the configuration
> @@ -52,7 +52,7 @@ config SPEAKUP_SYNTH_ACNTSA
>  config SPEAKUP_SYNTH_ACNTPC
>  	tristate "Accent PC synthesizer support"
>  	depends on ISA || COMPILE_TEST
> -	---help---
> +	help
>  		This is the Speakup driver for the accent pc
>  		synthesizer.  You can say y to build it into the kernel,
>  		or m to build it as a module.  See the configuration
> @@ -60,7 +60,7 @@ config SPEAKUP_SYNTH_ACNTPC
>  
>  config SPEAKUP_SYNTH_APOLLO
>  	tristate "Apollo II synthesizer support"
> -	---help---
> +	help
>  		This is the Speakup driver for the Apollo II
>  		synthesizer.  You can say y to build it into the kernel,
>  		or m to build it as a module.  See the configuration
> @@ -68,7 +68,7 @@ config SPEAKUP_SYNTH_APOLLO
>  
>  config SPEAKUP_SYNTH_AUDPTR
>  	tristate "Audapter synthesizer support"
> -	---help---
> +	help
>  		This is the Speakup driver for the Audapter synthesizer.
>  		 You can say y to build it into the kernel, or m to
>  		build it as a module.  See the configuration help on the
> @@ -76,7 +76,7 @@ config SPEAKUP_SYNTH_AUDPTR
>  
>  config SPEAKUP_SYNTH_BNS
>  	tristate "Braille 'n' Speak synthesizer support"
> -	---help---
> +	help
>  		This is the Speakup driver for the Braille 'n' Speak
>  		synthesizer.  You can say y to build it into the kernel,
>  		or m to build it as a module.  See the configuration
> @@ -84,8 +84,7 @@ config SPEAKUP_SYNTH_BNS
>  
>  config SPEAKUP_SYNTH_DECTLK
>  	tristate "DECtalk Express synthesizer support"
> -	---help---
> -
> +	help
>  		This is the Speakup driver for the DecTalk Express
>  		synthesizer.  You can say y to build it into the kernel,
>  		or m to build it as a module.  See the configuration
> @@ -93,8 +92,7 @@ config SPEAKUP_SYNTH_DECTLK
>  
>  config SPEAKUP_SYNTH_DECEXT
>  	tristate "DECtalk External (old) synthesizer support"
> -	---help---
> -
> +	help
>  		This is the Speakup driver for the DecTalk External
>  		(old) synthesizer.  You can say y to build it into the
>  		kernel, or m to build it as a module.  See the
> @@ -105,8 +103,7 @@ config SPEAKUP_SYNTH_DECPC
>  	depends on m
>  	depends on ISA || COMPILE_TEST
>  	tristate "DECtalk PC (big ISA card) synthesizer support"
> -	---help---
> -
> +	help
>  		This is the Speakup driver for the DecTalk PC (full
>  		length ISA) synthesizer.  You can say m to build it as
>  		a module.  See the configuration help on the Speakup
> @@ -127,8 +124,7 @@ config SPEAKUP_SYNTH_DECPC
>  config SPEAKUP_SYNTH_DTLK
>  	tristate "DoubleTalk PC synthesizer support"
>  	depends on ISA || COMPILE_TEST
> -	---help---
> -
> +	help
>  		This is the Speakup driver for the internal DoubleTalk
>  		PC synthesizer.  You can say y to build it into the
>  		kernel, or m to build it as a module.  See the
> @@ -138,8 +134,7 @@ config SPEAKUP_SYNTH_DTLK
>  config SPEAKUP_SYNTH_KEYPC
>  	tristate "Keynote Gold PC synthesizer support"
>  	depends on ISA || COMPILE_TEST
> -	---help---
> -
> +	help
>  		This is the Speakup driver for the Keynote Gold
>  		PC synthesizer.  You can say y to build it into the
>  		kernel, or m to build it as a module.  See the
> @@ -148,8 +143,7 @@ config SPEAKUP_SYNTH_KEYPC
>  
>  config SPEAKUP_SYNTH_LTLK
>  	tristate "DoubleTalk LT/LiteTalk synthesizer support"
> ----help---
> -
> +	help
>  		This is the Speakup driver for the LiteTalk/DoubleTalk
>  		LT synthesizer.  You can say y to build it into the
>  		kernel, or m to build it as a module.  See the
> @@ -158,8 +152,7 @@ config SPEAKUP_SYNTH_LTLK
>  
>  config SPEAKUP_SYNTH_SOFT
>  	tristate "Userspace software synthesizer support"
> -	---help---
> -
> +	help
>  		This is the software synthesizer device node.  It will
>  		register a device /dev/softsynth which midware programs
>  		and speech daemons may open and read to provide kernel
> @@ -169,8 +162,7 @@ config SPEAKUP_SYNTH_SOFT
>  
>  config SPEAKUP_SYNTH_SPKOUT
>  	tristate "Speak Out synthesizer support"
> -	---help---
> -
> +	help
>  		This is the Speakup driver for the Speakout synthesizer.
>  		 You can say y to build it into the kernel, or m to
>  		build it as a module.  See the configuration help on the
> @@ -178,8 +170,7 @@ config SPEAKUP_SYNTH_SPKOUT
>  
>  config SPEAKUP_SYNTH_TXPRT
>  	tristate "Transport synthesizer support"
> -	---help---
> -
> +	help
>  		This is the Speakup driver for the Transport
>  		synthesizer.  You can say y to build it into the kernel,
>  		or m to build it as a module.  See the configuration
> @@ -187,8 +178,7 @@ config SPEAKUP_SYNTH_TXPRT
>  
>  config SPEAKUP_SYNTH_DUMMY
>  	tristate "Dummy synthesizer driver (for testing)"
> -	---help---
> -
> +	help
>  		This is a dummy Speakup driver for plugging a mere serial
>  		terminal.  This is handy if you want to test speakup but
>  		don't have the hardware.  You can say y to build it into
> -- 
> 2.7.4
> 

-- 
Samuel
<y> update-menus: relocation error: update-menus: symbol _ZNSt9basic_iosIcSt11char_traitsIcEE4initEPSt15basic_streambufIcS1_E, version GLIBCPP_3.2 not defined in file libstdc++.so.5 with link time reference
<y> quoi que ça peut bien vouloir dire ?
<D> N a eu la meme merde
<y> c ça que ça veut dire ? wow, c'est bien crypté :)
 -+- #ens-mim s'entraide -+-

Powered by blists - more mailing lists