linux-kernel - [PATCH -next & -mmotm] platform/x86: fix PCENGINES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 25 Feb 2019 15:52:14 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        "Enrico Weigelt, metux IT consult" <info@...ux.net>
Subject: [PATCH -next & -mmotm] platform/x86: fix PCENGINES_APU2 Kconfig
 warning

From: Randy Dunlap <rdunlap@...radead.org>

Fix Kconfig warning for PCENGINES_APU2 symbol:

WARNING: unmet direct dependencies detected for KEYBOARD_GPIO_POLLED
  Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n] && GPIOLIB [=y]
  Selected by [y]:
  - PCENGINES_APU2 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y]

Add INPUT_KEYBOARD dependency for KEYBOARD_GPIO_POLLED.
Add LEDS_CLASS dependency for LEDS_GPIO.

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Enrico Weigelt, metux IT consult <info@...ux.net>
---
 drivers/platform/x86/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

--- mmotm-2019-0225-1340.orig/drivers/platform/x86/Kconfig
+++ mmotm-2019-0225-1340/drivers/platform/x86/Kconfig
@@ -1305,6 +1305,8 @@ config HUAWEI_WMI
 
 config PCENGINES_APU2
 	tristate "PC Engines APUv2/3 front button and LEDs driver"
+	depends on INPUT_KEYBOARD
+	depends on LEDS_CLASS
 	select GPIO_AMD_FCH
 	select KEYBOARD_GPIO_POLLED
 	select LEDS_GPIO