linux-kernel - Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22f84fb2-73ef-d0af-0552-2512912ae000@collabora.com>
Date:   Mon, 25 Feb 2019 13:23:46 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Cheng-yi Chiang <cychiang@...omium.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Nick Crews <ncrews@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        dlaurie@...omium.org, sfr@...b.auug.org.au,
        Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org
Subject: Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for
 wilco_ec

Hi Cheng-yi,

Attached the config that Randy sent.

Thanks,
 Enric
On 25/2/19 11:22, Cheng-yi Chiang wrote:
> On Mon, Feb 25, 2019 at 6:11 PM Enric Balletbo i Serra
> <enric.balletbo@...labora.com> wrote:
>>
>> Hi Randy,
>>
>> Thanks for the report
>>
>> On 22/2/19 17:50, Randy Dunlap wrote:
>>> On 2/20/19 11:57 PM, Enric Balletbo i Serra wrote:
>>>> Hi,
>>>>
>>>> On 21/2/19 0:09, Randy Dunlap wrote:
>>>>> On 2/20/19 2:11 PM, Nick Crews wrote:
>>>>>> In the initial version of the Wilco EC Driver, the
>>>>>> dependency order was wrong. It before was possible to
>>>>>> select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without
>>>>>> having CONFIG_CROS_EC_LPC_MEC. This was wrong, since
>>>>>> WILCO_EC depends upon CONFIG CROS_EC_LPC_MEC, not the
>>>>>> other way around.
>>>>>>
>>>>>> Fixes: 1733c32834e5d1 ("platform/chrome: Add new driver for Wilco EC")
>>>>>> Signed-off-by: Nick Crews <ncrews@...omium.org>
>>>>>
>>>>> Reported-by: Randy Dunlap <rdunlap@...radead.org>
>>>>> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested
>>>>>
>>>>
>>>> As this is [-next] material I squashed that commit and queued for 5.1
>>>
>>> Hi,
>>>
>>> on linux-next of 20190222, I now see this build error + Kconfig warnings:
>>>
>>> (this is on i386; randconfig file is attached)
>>>
>>> WARNING: unmet direct dependencies detected for SND_SOC_CROS_EC_CODEC
>>>   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && MFD_CROS_EC [=n]
>>>   Selected by [y]:
>>>   - SND_SOC_SDM845 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && QCOM_APR [=y]
>>
>>
>> This error seems to be introduced by following commit.
>>
>> commit 74c6ecf4194ebed285b29964a950e0cd7414fe19
>> Author: Cheng-Yi Chiang <cychiang@...omium.org>
>> Date:   Mon Feb 18 12:18:19 2019 +0800
>>
>>     ASoC: qcom: Kconfig: select dmic for sdm845
>>
>>     sdm845 uses dmic on EC so it should select CROS_EC_CODEC.
>>
>>     Signed-off-by: Cheng-Yi Chiang <cychiang@...omium.org>
>>     Signed-off-by: Mark Brown <broonie@...nel.org>
>>
>> The problem is that this commit selects CROS_EC_CODEC but the CROS_EC_CODEC
>> depends on MFD_CROS_EC which is not selected.
>>
>> A question for Cheng-Yi, I suppose that the answer is yes but worth ask because
>> I don't know about this device. Is the sdm845 a chromebook with and embedded
>> controller right?
>>
>> Thanks,
>> Enric
>>
> 
> Hi Enric,
> Yes you are right.
> Sorry for causing the trouble.
> I will post a patch to fix it.
> 
> Could you please let me know what is the command for your build ?
> Currently I am using command like
> ARCH=x86_64 make allyesconfig
> ARCH=x86_64 make -j64
> 
> to verify the build, which is not useful to catch bug like this.
> If you have any other good tip for checking this kind of error please
> kindly let me know.
> Thanks!
> 
>>>
>>> ld: sound/soc/codecs/cros_ec_codec.o: in function `ec_command_no_resp':
>>> cros_ec_codec.c:(.text+0x50): undefined reference to `cros_ec_cmd_xfer_status'
>>> ld: sound/soc/codecs/cros_ec_codec.o: in function `mic_gain_get':
>>> cros_ec_codec.c:(.text+0x5a8): undefined reference to `cros_ec_cmd_xfer_status'
>>>
>>>
>>>

View attachment "config-r4148" of type "text/plain" (106063 bytes)