linux-kernel - Re: [PATCH 11/11] perf tools report: Implement browsing of individual samples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190225133335.GM16922@tassilo.jf.intel.com>
Date:   Mon, 25 Feb 2019 05:33:35 -0800
From:   Andi Kleen <ak@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        jolsa@...nel.org, namhyung@...nel.org, eranian@...gle.com
Subject: Re: [PATCH 11/11] perf tools report: Implement browsing of
 individual samples

On Mon, Feb 25, 2019 at 01:56:15PM +0100, Jiri Olsa wrote:
> On Sun, Feb 24, 2019 at 07:37:22AM -0800, Andi Kleen wrote:
> 
> SNIP
> 
> > +static void hists__res_sample(struct hist_entry *he, struct perf_sample *sample)
> > +{
> > +	struct res_sample *r;
> > +	int j;
> > +
> > +	if (!he->res_samples) {
> > +		he->res_samples = calloc(sizeof(struct res_sample),
> > +					symbol_conf.res_sample);
> > +		if (!he->res_samples)
> > +			return;
> > +	}
> > +	if (he->num_res < symbol_conf.res_sample) {
> > +		j = he->num_res++;
> > +	} else {
> > +		j = random_max(++he->num_res + 1);
> 
> will he->num_res keep raising all the time?

Yes, but the display code limits it to symbol_conf.res_samples

That was intentional so that we can keep track of the total
number of samples. Plan was to eventually display it somewhere
so that the users know how many of the samples are covered
(currently it is not though) 

-Andi