linux-kernel - Re: [PATCH v2] xfrm: correctly check policy index in verify_newpolicy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190225134330.ohrvjssdnsmcyxnp@gondor.apana.org.au>
Date:   Mon, 25 Feb 2019 21:43:30 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     steffen.klassert@...unet.com, davem@...emloft.net,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] xfrm: correctly check policy index in
 verify_newpolicy_info

On Mon, Feb 25, 2019 at 05:56:00PM +0800, Yue Haibing wrote:
>
> the check. Then __xfrm_policy_unlink use the index to access array policy_count
> whose size is XFRM_POLICY_MAX * 2, triggering out of bounds access.

No it doesn't.  Even if it did the bug would be in __xfrm_policy_unlink
and not here.

Your patch makes no sense.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt