linux-kernel - Re: [PATCH v1 1/3] perf diff: Support --time filter option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190225141923.GF14757@krava>
Date:   Mon, 25 Feb 2019 15:19:23 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     "Jin, Yao" <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v1 1/3] perf diff: Support --time filter option

On Mon, Feb 25, 2019 at 10:12:08PM +0800, Jin, Yao wrote:
> 
> 
> On 2/25/2019 9:38 PM, Jiri Olsa wrote:
> > On Mon, Feb 25, 2019 at 09:42:42PM +0800, Jin Yao wrote:
> > 
> > SNIP
> > 
> > >   COMPARISON
> > >   ----------
> > >   The comparison is governed by the baseline file. The baseline perf.data
> > > diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> > > index 751e197..ddc41e7 100644
> > > --- a/tools/perf/builtin-diff.c
> > > +++ b/tools/perf/builtin-diff.c
> > > @@ -19,12 +19,21 @@
> > >   #include "util/util.h"
> > >   #include "util/data.h"
> > >   #include "util/config.h"
> > > +#include "util/time-utils.h"
> > >   #include <errno.h>
> > >   #include <inttypes.h>
> > >   #include <stdlib.h>
> > >   #include <math.h>
> > > +struct perf_diff {
> > > +	struct perf_tool	tool;
> > > +	const char		*time_str;
> > > +	struct perf_time_interval *ptime_range;
> > > +	int			range_size;
> > > +	int			range_num;
> > 
> > please align the members
> > 
> 
> Not aligned? Sorry, could you give me an example?

one extra tab before the name:

	struct perf_tool		 tool;
	const char			*time_str;
	struct perf_time_interval	*ptime_range;
	int				 range_size;
	int				 range_num;

jirka