linux-kernel - Re: [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82fe83ba-b967-66ee-1299-1cd98072089a@collabora.com>
Date:   Mon, 25 Feb 2019 15:37:21 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Cheng-Yi Chiang <cychiang@...omium.org>,
        linux-kernel@...r.kernel.org
Cc:     Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
        rdunlap@...radead.org, ncrews@...omium.org, bleung@...omium.org,
        dgreid@...omium.org, tzungbi@...omium.org,
        Rohit kumar <rohitkr@...eaurora.org>
Subject: Re: [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845

Hi,

On 25/2/19 14:54, Cheng-Yi Chiang wrote:
> SND_SOC_CROS_EC_CODEC depends on MFD_CROS_EC.
> Add that dependency to SND_SOC_SDM845 to fix unmet direct dependencies
> warning.
> 
> Fixes: 74c6ecf4194e (ASoC: qcom: Kconfig: select dmic for sdm845)

Reported-by: Randy Dunlap <rdunlap@...radead.org>

> Signed-off-by: Cheng-Yi Chiang <cychiang@...omium.org>

Tested-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

Thanks,
Enric

> ---
>  sound/soc/qcom/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> index 8f206cb4fcc0..75ceb04d8bf0 100644
> --- a/sound/soc/qcom/Kconfig
> +++ b/sound/soc/qcom/Kconfig
> @@ -98,7 +98,7 @@ config SND_SOC_MSM8996
>  
>  config SND_SOC_SDM845
>  	tristate "SoC Machine driver for SDM845 boards"
> -	depends on QCOM_APR
> +	depends on QCOM_APR && MFD_CROS_EC
>  	select SND_SOC_QDSP6
>  	select SND_SOC_QCOM_COMMON
>  	select SND_SOC_RT5663
>