linux-kernel - Re: [PATCH] nvmet: disable direct I/O when unavailable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a85e85d6-6a06-7663-3a12-710b6467dedd@acm.org>
Date:   Mon, 25 Feb 2019 06:49:04 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Johannes Thumshirn <jthumshirn@...e.de>,
        Max Gurtovoy <maxg@...lanox.com>,
        Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>,
        Christoph Hellwig <hch@....de>
Cc:     Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH] nvmet: disable direct I/O when unavailable

On 2/25/19 1:37 AM, Johannes Thumshirn wrote:
> On 24/02/2019 11:54, Max Gurtovoy wrote:
>> What is the status of iSCSI/SRP targets in this case ?
> 
> iSCSI/SRP passes in the following:
> 
>   /*
>    * Use O_DSYNC by default instead of O_SYNC to forgo syncing
>    * of pure timestamp updates.
>    */
>   flags = O_RDWR | O_CREAT | O_LARGEFILE | O_DSYNC;

That code fragment comes from the LIO file backend. There is no 
requirement for a SCSI target core file backend to use O_DSYNC. SCST 
allows users to choose whether or not O_DSYNC should be used:

	if (virt_dev->wt_flag && !virt_dev->nv_cache)
		open_flags |= O_DSYNC;

Bart.