linux-kernel - Re: [PATCH v1 1/3] ARM: dts: stm32: Add Vivante GPU support on STM32MP157c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Feb 2019 16:48:34 +0100
From:   Pierre Yves MORDRET <pierre-yves.mordret@...com>
To:     Lucas Stach <l.stach@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>
CC:     <devicetree@...r.kernel.org>,
        Philippe Cornu <philippe.cornu@...com>,
        <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v1 1/3] ARM: dts: stm32: Add Vivante GPU support on
 STM32MP157c

Hi Lucas

sorry for the delay : winter season :)

On 2/15/19 5:11 PM, Lucas Stach wrote:
> Hi Pierre-Yves,
> 
> Am Freitag, den 15.02.2019, 16:58 +0100 schrieb Pierre-Yves MORDRET:
>> Append Vivante GPU DT configuration.
>>
>> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@...com>
>> ---
>>  arch/arm/boot/dts/stm32mp157c.dtsi | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
>> index f8bbfff..29540bc 100644
>> --- a/arch/arm/boot/dts/stm32mp157c.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi
>> @@ -1106,6 +1106,16 @@
>>>  			status = "disabled";
>>>  		};
>>  
>> +		gpu: gpu@...00000 {
>> +			compatible = "vivante,gc";
>> +			reg = <0x59000000 0x800>;
>> +			interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&rcc GPU>, <&rcc GPU_K>;
>> +			clock-names = "bus" ,"core";
> 
> Is this a 2D only core? If it is also 3D capable the binding says you
> need to specify the shader clock (may be the same clock feeding the
> core).

Yes, this is a 3D core.
As for "shader" clock both "core" and "shader" are connected internally. This is
why no "shader" input clock is seen.
Nonetheless we may add it for bindings compliance but from STM32MP1 pov this
won't make any changes.

Hope it clarifies.

Regards
> 
> Regards,
> Lucas
> 
>> +			resets = <&rcc GPU_R>;
>> +			status = "disabled";
>> +		};
>> +
>>  		dsi: dsi@...00000 {
>>  			compatible = "st,stm32-dsi";
>>  			reg = <0x5a000000 0x800>;