linux-kernel - Re: [RESEND] [PATCH] Hold back_lock when calling iscsi_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <977e50ae-7623-65ce-8851-154026f63f2d@suse.com>
Date:   Mon, 25 Feb 2019 09:39:04 -0800
From:   Lee Duncan <lduncan@...e.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>,
        Lee Duncan <leeman.duncan@...il.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        cleech@...hat.com
Cc:     hare@...e.de
Subject: Re: [RESEND] [PATCH] Hold back_lock when calling iscsi_complete_task

On 2/25/19 2:02 AM, Johannes Thumshirn wrote:
> On 22/02/2019 17:29, Lee Duncan wrote:
>> From: Lee Duncan <lduncan@...e.com>
>>
>> If there is an error queueing an iscsi command in
>> iscsi_queuecommand(), for example if the transport fails
>> to take the command in sessuin->tt->xmit_task(), then
>> the error path can call iscsi_complete_task() without
>> first aquiring the back_lock as required. This can
>> lead to things like ITT pool can get corrupt, resulting
>> in duplicate ITTs being sent out.
>>
>> The solution is to hold the back_lock around
>> iscsi_complete_task() calls, and to add a little commenting
>> to help others understand when back_lock must be held.
> 
> You're missing a S-o-b here.
> 
> Byte,
> 	Johannes
> 

Doh!

I will resend.

-- 
The Lee-Man