lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 25 Feb 2019 20:42:03 +0100
From:   Borislav Petkov <>
To:     Linus Torvalds <>
Cc:     LKML <>,
        Andy Lutomirski <>,
        Jann Horn <>,
        Peter Zijlstra <>,
        the arch/x86 maintainers <>,
        "Tobin C. Harding" <>
Subject: Re: [PATCH] x86/uaccess: Remove unused __addr_ok() macro

On Mon, Feb 25, 2019 at 11:20:42AM -0800, Linus Torvalds wrote:
> On Mon, Feb 25, 2019 at 11:11 AM Borislav Petkov <> wrote:
> >
> > This was caught while staring at the whole {set,get}_fs() machinery.
> Heh.
> You should probably have researched _when_ it became unused.
> That seems to have happened in commit 5723aa993d83 ("x86: use the new
> generic strnlen_user() function") which removed the single user from
> the x86-32 version of strnlen_user(), which used to have
>         unsigned long mask = -__addr_ok(s);

Yap, found it. I still have

$ git log -p -G__addr_ok --pickaxe-all

in one of the shells' history here.

I'll add that to the commit message.



Good mailing practices for 400: avoid top-posting and trim the reply.

Powered by blists - more mailing lists