linux-kernel - Re: [PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   25 Feb 2019 10:18:06 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:     <twischer@...adit-jv.com>, <patch@...a-project.org>,
        <broonie@...nel.org>, <perex@...ex.cz>, <tiwai@...e.com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        Jiada Wang <jiada_wang@...tor.com>
Subject: Re: [PATCH] ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address


Hi Jiada, again

> > Currently each SSI unit 's busif dma address is calculated by
> > following calculation formulation:
> > 0xec540000 + 0x1000 * id + busif / 4 * 0xA000 + busif % 4 * 0x400
> > 
> > But according to user manual 41.1.4 Register Configuration
> > ssi9 4/5/6/7 busif data register address
> > (SSI9_4_BUSIF/SSI9_5_BUSIF/SSI9_6_BUSIF/SSI9_7_BUSIF)
> > are out of this rule.
> > 
> > This patch updates the calculation formulation to correct
> > ssi9 4/5/6/7 busif data register address
> > 
> > Fixes: commit 5e45a6fab3b9 ("ASoc: rsnd: dma: Calculate dma address with consider of BUSIF")
> > Signed-off-by: Jiada Wang <jiada_wang@...tor.com>
> > Signed-off-by: Timo Wischer <twischer@...adit-jv.com>
> > ---
> 
> We don't need below anymore by this patch ?
> 
> 	--- dma.c ----
> 	/*
> 	 * FIXME
> 	 *
> 	 * We can't support SSI9-4/5/6/7, because its address is
> 	 * out of calculation rule
> 	 */
> 	if ((id == 9) && (busif >= 4))
> 		dev_err(dev, "This driver doesn't support SSI%d-%d, so far",
> 			id, busif);

Oops, next patch is removing this.
Please ignore this mail.