linux-kernel - Re: [PATCH V2] staging: wilc1000: fix incorrent type assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8bc95d6e-3350-a6a3-fb63-f9da9e0b8c0b@microchip.com>
Date:   Tue, 26 Feb 2019 08:24:37 +0000
From:   <Ajay.Kathat@...rochip.com>
To:     <tsu.yubo@...il.com>, <Adham.Abozaeid@...rochip.com>,
        <gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
        <yuzibode@....com>
CC:     <linux-wireless@...r.kernel.org>, <devel@...verdev.osuosl.org>
Subject: Re: [PATCH V2] staging: wilc1000: fix incorrent type assignment

Thanks.

On 2/26/2019 12:55 PM, Bo YU wrote:
> Fix sparse warning:
> 
> drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in assignment (different base types)
> drivers/staging/wilc1000/host_interface.c:450:30:    expected restricted __le16 [usertype] beacon_period
> drivers/staging/wilc1000/host_interface.c:450:30:    got unsigned short [usertype] beacon_interval
> drivers/staging/wilc1000/host_interface.c:451:25: warning: incorrect type in assignment (different base types)
> drivers/staging/wilc1000/host_interface.c:451:25:    expected restricted __le16 [usertype] cap_info
> drivers/staging/wilc1000/host_interface.c:451:25:    got unsigned short [usertype] capability
> 
> Signed-off-by: Bo YU <tsu.yubo@...il.com>

Reviewed-by: Ajay Singh <ajay.kathat@...rochip.com>

> ---
> V2: use cpu_to_le16 assign valid type according to Ajay's suggestions
> ---
>  drivers/staging/wilc1000/host_interface.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 50dc2dd942f5..20349af2ed30 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -447,8 +447,8 @@ void *wilc_parse_join_bss_param(struct cfg80211_bss *bss,
>  	if (!param)
>  		return NULL;
>  
> -	param->beacon_period = bss->beacon_interval;
> -	param->cap_info = bss->capability;
> +	param->beacon_period = cpu_to_le16(bss->beacon_interval);
> +	param->cap_info = cpu_to_le16(bss->capability);
>  	param->bss_type = WILC_FW_BSS_TYPE_INFRA;
>  	param->ch = ieee80211_frequency_to_channel(bss->channel->center_freq);
>  	ether_addr_copy(param->bssid, bss->bssid);
>