linux-kernel - Re: [PATCH v1] usb: chipidea: tegra: Fix missed ci_hdrc_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190226105615.GA12397@kroah.com>
Date:   Tue, 26 Feb 2019 11:56:15 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Peter Chen <peter.chen@....com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] usb: chipidea: tegra: Fix missed
 ci_hdrc_remove_device()

On Mon, Feb 25, 2019 at 08:07:15AM +0300, Dmitry Osipenko wrote:
> В Mon, 25 Feb 2019 02:27:19 +0000
> Peter Chen <peter.chen@....com> пишет:
> 
> >  
> > > 
> > > Fixes: dfebb5f43a78827a ("usb: chipidea: Add support for
> > > Tegra20/30/114/124")  
> > 
> > I suppose you need to apply at stable tree too, right?
> > 
> 
> It is enough to have the "Fixes" tag to get patch backported into all
> relevant kernel versions.

No it is not.  My scripts do NOT trigger off of the fixes: tag, please
read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.


> > > Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> > > ---
> > >  drivers/usb/chipidea/ci_hdrc_tegra.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c
> > > b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > > index 772851bee99b..12025358bb3c 100644
> > > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c
> > > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c
> > > @@ -130,6 +130,7 @@ static int tegra_udc_remove(struct
> > > platform_device *pdev) {
> > >  	struct tegra_udc *udc = platform_get_drvdata(pdev);
> > > 
> > > +	ci_hdrc_remove_device(udc->dev);
> > >  	usb_phy_set_suspend(udc->phy, 1);
> > >  	clk_disable_unprepare(udc->clk);
> > >   
> >  
> > Acked-by: Peter Chen <peter.chen@....com>
> > 
> > Hi Greg, would you still accept the bug-fix for this release (v5.0)?
> > Or I send you later?

I can pick it up now, thanks.

greg k-h