linux-kernel - Re: [PATCH v4 0/3] Mark clocks as critical for MT6797

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Feb 2019 13:59:44 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     matthias.bgg@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
        kevin-cw.chen@...iatek.com, mars.cheng@...iatek.com
Cc:     sean.wang@...iatek.com, jasu@...motys.info,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH v4 0/3] Mark clocks as critical for MT6797



On 14/02/2019 17:30, matthias.bgg@...nel.org wrote:
> From: Matthias Brugger <mbrugger@...e.com>
> 
> Jasper send this series some month ago. As there was no reaction from
> his side, I'll do a friendly take-over.
> I tested the patches on my Helios X20 boards and they fix the issue.
> I didn't add a Tested-by tag as I added my Signed-off-by.
> 
> Changes since v3:
> - add comments explaining why the clock muxer and gates are marked
>   as critical
> 
> Changes since v2 (https://patchwork.kernel.org/patch/10686759/):
> - axi_sel is not needed, drop CLK_IS_CRITICAL for it.
> - update commit message
> - add Acked-by from Mars
> 
> Changes since v1:
> - add a fixes tag.
> 

Steven, Mike any comments on this?

Regards,
Matthias

> ---
> 
> Currently, DRAM-related clocks and the axi_sel MUX are not marked with
> CLK_IS_CRITICAL for MT6797. This causes memory corruption when the
> system is booted without clk_ignore_unused.
> 
> This patchset
> 
> 1. Makes it possible to mark outputs of MUXes as critical by introducing
>    a new macro, MUX_FLAGS,
> 2. Makes it possible to mark gates as critical by adding flags to
>    mtk_gate, and
> 3. Marks axi_sel, ddrphycfg_sel, infra_dramc_f26m and infra_dramc_b_f26m
>    as critical.
> 
> The addition of flags to mtk_gate also exists in the patch series "Add
> basic and clock support for Mediatek MT8183 SoC" [1].  The type of
> flags is unsigned int in that series, but the real type is unsigned
> long, so my patch differs from that patch.
> 
> [1] https://patchwork.kernel.org/patch/10549953/
> 
> Jasper Mattsson (3):
>   clk: mediatek: Add MUX_FLAGS macro
>   clk: mediatek: Add flags to mtk_gate
>   clk: mediatek: Mark bus and DRAM related clocks as critical
> 
>  drivers/clk/mediatek/clk-gate.c   |  4 +-
>  drivers/clk/mediatek/clk-gate.h   |  3 +-
>  drivers/clk/mediatek/clk-mt6797.c | 68 +++++++++++++++++++------------
>  drivers/clk/mediatek/clk-mtk.c    |  2 +-
>  drivers/clk/mediatek/clk-mtk.h    |  9 +++-
>  5 files changed, 56 insertions(+), 30 deletions(-)
>