linux-kernel - Re: [PATCH v3 0/5] Enable wm8524 on i.MX8MQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Feb 2019 15:05:20 +0200
From:   Daniel Baluta <daniel.baluta@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Daniel Baluta <daniel.baluta@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "S.j. Wang" <shengjiu.wang@....com>,
        "angus@...ea.ca" <angus@...ea.ca>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        Abel Vesa <abel.vesa@....com>,
        "ccaione@...libre.com" <ccaione@...libre.com>,
        "baruch@...s.co.il" <baruch@...s.co.il>,
        "agx@...xcpu.org" <agx@...xcpu.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        "kuninori.morimoto.gx@...esas.com" <kuninori.morimoto.gx@...esas.com>
Subject: Re: [PATCH v3 0/5] Enable wm8524 on i.MX8MQ

On Tue, Feb 26, 2019 at 2:53 PM Fabio Estevam <festevam@...il.com> wrote:
>
> Hi Daniel,
>
> On Tue, Feb 26, 2019 at 4:08 AM Daniel Baluta <daniel.baluta@....com> wrote:
> >
> > On i.MX8MQ we can start the party using the wm8524 codec
> > which gets it's data through the SAI2 interface.
> >
> > In order to make it work this patch series enables the SDMA nodes,
> > sets the correct pinctrl configuration and uses the simple card
> > machine driver to put everything together.
> >
> > Changes since v2:
> >         - s/QM/MQ after Chris comments
> >
> > Changes since v1:
> >         - added cover letter
> >         - remove "fsl,imx8mq-sdma" compatible for sdma.
>
> Why? It is good practice to add the new compatible entry.

I get your point here. But for the moment it is identical with
"fsl,imx7d-sdma" so there is no need to add it now!

See the discussion here, and comment from Lucas:

https://lkml.org/lkml/2019/1/28/194

So, I prefer to keep it simple.

>
> In case we find out a need for a fix that only affects imx8mq in the
> future we can do that by using the specific compatible and no dts
> change will be needed.
>
> >
> > Daniel Baluta (5):
> >   arm64: dts: imx8mq: Add SDMA nodes
> >   arm64: dts: imx8mq: Add SAI2 node
> >   arm64: dts: imx8mq: Add SAI pinctrl configuration
> >   arm64: dts: imx8mq: Enable SAI2 for wm8524 codec
> >   arm64: dts: imx8mq: Enable wm8524 codec
>
> I would suggest making the last three patches as a single one.

I'm not convinced about this. I try to separate patches like this
in order for people to really understand step by step how
audio is enabled on i.MX board.

I will give a second thought though. Maybe 3/5 and 4/5 could be squashed
together.

>
> Also, please make the Subject as: arm64: dts: imx8mq-evk when a patch
> is specific to the imx8mq-evk dts.

Indeed, will fix in next version.