linux-kernel - Re: thinkpad_acpi: Battery quirk for Thinkpad 11e (4th gen)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Feb 2019 17:04:50 +0100
From:   Jouke Witteveen <j.witteveen@...il.com>
To:     Ken Milmore <ken.milmore@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Henrique de Moraes Holschuh <hmh@....eng.br>
Subject: Re: thinkpad_acpi: Battery quirk for Thinkpad 11e (4th gen)

On Sun, Feb 24, 2019 at 3:58 PM Ken Milmore <ken.milmore@...il.com> wrote:
> Setting charge thresholds seems to basically work, but one thing worth
> mentioning is that charge_start_threshold and charge_stop_threshold
> appear to be tied together; AFAICT setting one also sets the other to
> the same value. The battery does seem to start charging whenever it
> falls below the common threshold, I have it set at 80% and it has kept
> the battery floating around 79%.

I observe the same behavior on my Thinkpad 13. Maybe there is a bug in
the driver, but it could also be a bug in the firmware.

> diff -uprN linux-source-4.19~/drivers/platform/x86/thinkpad_acpi.c linux-source-4.19/drivers/platform/x86/thinkpad_acpi.c
> --- linux-source-4.19~/drivers/platform/x86/thinkpad_acpi.c     2019-02-24 13:27:29.341331227 +0000
> +++ linux-source-4.19/drivers/platform/x86/thinkpad_acpi.c      2019-02-24 13:09:28.710982438 +0000
> @@ -9619,6 +9619,7 @@ static const struct tpacpi_quirk battery
>         TPACPI_Q_LNV3('R', '0', 'B', true), /* Thinkpad 11e gen 3 */
>         TPACPI_Q_LNV3('R', '0', 'C', true), /* Thinkpad 13 */
>         TPACPI_Q_LNV3('R', '0', 'J', true), /* Thinkpad 13 gen 2 */
> +       TPACPI_Q_LNV3('R', '0', 'K', true), /* Thinkpad 11e gen 4 */

Personally, I would add the line below the 11e gen 3.

>  };
>
>  static int __init tpacpi_battery_init(struct ibm_init_struct *ibm)