linux-kernel - Re: [PATCH 2/2] regulator: cpcap: Constify omap4_regulators and xoom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190226160718.b2lk4cgtf2k2xxoe@earth.universe>
Date:   Tue, 26 Feb 2019 17:07:18 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Axel Lin <axel.lin@...ics.com>
Cc:     Mark Brown <broonie@...nel.org>, Peter Geis <pgwipeout@...il.com>,
        Tony Lindgren <tony@...mide.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regulator: cpcap: Constify omap4_regulators and
 xoom_regulators

Hi,

On Tue, Feb 26, 2019 at 01:52:30PM +0800, Axel Lin wrote:
> They should never change, make them const.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

-- Sebastian

>  drivers/regulator/cpcap-regulator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/cpcap-regulator.c b/drivers/regulator/cpcap-regulator.c
> index c15ced1b5968..e7dab5c4d1d1 100644
> --- a/drivers/regulator/cpcap-regulator.c
> +++ b/drivers/regulator/cpcap-regulator.c
> @@ -334,7 +334,7 @@ static const unsigned int vaudio_val_tbl[] = { 0, 2775000, };
>   * SW1 to SW4 and SW6 seems to be unused for mapphone. Note that VSIM and
>   * VSIMCARD have a shared resource assignment bit.
>   */
> -static struct cpcap_regulator omap4_regulators[] = {
> +static const struct cpcap_regulator omap4_regulators[] = {
>  	CPCAP_REG(SW1, CPCAP_REG_S1C1, CPCAP_REG_ASSIGN2,
>  		  CPCAP_BIT_SW1_SEL, unknown_val_tbl,
>  		  0, 0, 0, 0, 0),
> @@ -410,7 +410,7 @@ static struct cpcap_regulator omap4_regulators[] = {
>  	{ /* sentinel */ },
>  };
>  
> -static struct cpcap_regulator xoom_regulators[] = {
> +static const struct cpcap_regulator xoom_regulators[] = {
>  	CPCAP_REG(SW1, CPCAP_REG_S1C1, CPCAP_REG_ASSIGN2,
>  		  CPCAP_BIT_SW1_SEL, unknown_val_tbl,
>  		  0, 0, 0, 0, 0),
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)