linux-kernel - Re: [PATCH] watchdog: smsc37b787_wdt: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9aad06b-7917-328d-30fb-1c3e873bbe35@embeddedor.com>
Date:   Tue, 26 Feb 2019 11:42:06 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] watchdog: smsc37b787_wdt: Mark expected switch
 fall-through



On 2/18/19 10:08 AM, Guenter Roeck wrote:
> On 2/14/19 12:16 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/watchdog/smsc37b787_wdt.c: In function ‘wb_smsc_wdt_ioctl’:
>> drivers/watchdog/smsc37b787_wdt.c:480:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>     wb_smsc_wdt_set_timeout(timeout);
>>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/watchdog/smsc37b787_wdt.c:482:2: note: here
>>    case WDIOC_GETTIMEOUT:
>>    ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> 

Thank you, Guenter.


Friendly ping:

Who can take this?

Thanks
--
Gustavo

>> ---
>>   drivers/watchdog/smsc37b787_wdt.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/smsc37b787_wdt.c b/drivers/watchdog/smsc37b787_wdt.c
>> index 445ea1ad1fa9..c768dcd53034 100644
>> --- a/drivers/watchdog/smsc37b787_wdt.c
>> +++ b/drivers/watchdog/smsc37b787_wdt.c
>> @@ -478,7 +478,7 @@ static long wb_smsc_wdt_ioctl(struct file *file,
>>               return -EINVAL;
>>           timeout = new_timeout;
>>           wb_smsc_wdt_set_timeout(timeout);
>> -        /* fall through and return the new timeout... */
>> +        /* fall through - and return the new timeout... */
>>       case WDIOC_GETTIMEOUT:
>>           new_timeout = timeout;
>>           if (unit == UNIT_MINUTE)
>>
>