linux-kernel - Re: [PATCH] watchdog: pc87413: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190226175519.GA26692@roeck-us.net>
Date:   Tue, 26 Feb 2019 09:55:19 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] watchdog: pc87413: Mark expected switch fall-through

On Tue, Feb 26, 2019 at 11:46:09AM -0600, Gustavo A. R. Silva wrote:
> Hi all,
> 
> Friendly ping:
> 
> Who can take this?
> 
Wim, presumably.

Guenter

> Thanks
> --
> Gustavo
> 
> 
> On 2/18/19 11:50 AM, Gustavo A. R. Silva wrote:
> > 
> > 
> > On 2/18/19 10:09 AM, Guenter Roeck wrote:
> >> On 2/14/19 12:26 PM, Gustavo A. R. Silva wrote:
> >>> In preparation to enabling -Wimplicit-fallthrough, mark switch
> >>> cases where we are expecting to fall through.
> >>>
> >>> This patch fixes the following warning:
> >>>
> >>> drivers/watchdog/pc87413_wdt.c: In function ‘pc87413_ioctl’:
> >>> drivers/watchdog/pc87413_wdt.c:439:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >>>     pc87413_refresh();
> >>>     ^~~~~~~~~~~~~~~~~
> >>> drivers/watchdog/pc87413_wdt.c:441:2: note: here
> >>>    case WDIOC_GETTIMEOUT:
> >>>    ^~~~
> >>>
> >>> Warning level 3 was used: -Wimplicit-fallthrough=3
> >>>
> >>> Notice that, in this particular case, the code comment is modified
> >>> in accordance with what GCC is expecting to find.
> >>>
> >>> This patch is part of the ongoing efforts to enable
> >>> -Wimplicit-fallthrough.
> >>>
> >>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> >>
> >> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> >>
> > 
> > Thanks, Guenter.
> > 
> > --
> > Gustavo
> >