linux-kernel - Re: [Drbd-dev] [PATCH] block: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Feb 2019 13:31:22 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Roland Kammerer <roland.kammerer@...bit.com>
Cc:     Philipp Reisner <philipp.reisner@...bit.com>,
        Lars Ellenberg <lars.ellenberg@...bit.com>,
        Jens Axboe <axboe@...nel.dk>,
        Joshua Morris <josh.h.morris@...ibm.com>,
        Philip Kelleher <pjk1939@...ux.ibm.com>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        drbd-dev@...ts.linbit.com, Kees Cook <keescook@...omium.org>
Subject: Re: [Drbd-dev] [PATCH] block: Mark expected switch fall-throughs



On 1/29/19 3:42 AM, Roland Kammerer wrote:
> On Wed, Jan 23, 2019 at 12:45:01AM -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> ---
>>  drivers/block/drbd/drbd_int.h      | 2 +-
>>  drivers/block/drbd/drbd_receiver.c | 4 ++--
>>  drivers/block/drbd/drbd_req.c      | 2 +-
>>  drivers/block/rsxx/core.c          | 1 +
>>  4 files changed, 5 insertions(+), 4 deletions(-)
>>
> 
> Hi Gustavo,
> 
> as also discussed with Lars in person, obviously OK for the DRBD part.
> 
> Acked-by: Roland Kammerer <roland.kammerer@...bit.com>
> 

Thank you, Roland.

Friendly ping:

Who can take this, please?

Thanks
--
Gustavo