linux-kernel - [PATCH 8/8] PCI: rpadlpar: fix a leaked reference by adding missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1551242443-27300-8-git-send-email-wen.yang99@zte.com.cn>
Date:   Wed, 27 Feb 2019 12:40:43 +0800
From:   Wen Yang <wen.yang99@....com.cn>
To:     benh@...nel.crashing.org
Cc:     paulus@...ba.org, mpe@...erman.id.au, tyreld@...ux.vnet.ibm.com,
        bhelgaas@...gle.com, linuxppc-dev@...ts.ozlabs.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        ryder.lee@...iatek.com, lorenzo.pieralisi@....com,
        matthias.bgg@...il.com, linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, rjui@...adcom.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        thomas.petazzoni@...tlin.com, shawn.lin@...k-chips.com,
        heiko@...ech.de, linux-rockchip@...ts.infradead.org,
        minghuan.Lian@....com, mingkai.hu@....com, roy.zang@....com,
        hayashi.kunihiko@...ionext.com, yamada.masahiro@...ionext.com,
        kishon@...com, linux-omap@...r.kernel.org, wang.yi59@....com.cn,
        Wen Yang <wen.yang99@....com.cn>
Subject: [PATCH 8/8] PCI: rpadlpar: fix a leaked reference by adding missing of_node_put

The call to of_find_node_by_name returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./drivers/pci/hotplug/rpadlpar_core.c:55:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 42, but without a corresponding object release within this function

Signed-off-by: Wen Yang <wen.yang99@....com.cn>
Cc: Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Paul Mackerras <paulus@...ba.org>
Cc: Michael Ellerman <mpe@...erman.id.au>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>
Cc: linux-pci@...r.kernel.org
Cc: linuxppc-dev@...ts.ozlabs.org
Cc: linux-kernel@...r.kernel.org
---
 drivers/pci/hotplug/rpadlpar_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
index e2356a9..f3f42ff 100644
--- a/drivers/pci/hotplug/rpadlpar_core.c
+++ b/drivers/pci/hotplug/rpadlpar_core.c
@@ -52,6 +52,7 @@ static struct device_node *find_vio_slot_node(char *drc_name)
 			break;
 	}
 
+	of_node_put(parent);
 	return dn;
 }
 
-- 
2.9.5