linux-kernel - Re: [PATCH] rapidio/mport_cdev: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7bc50a9-0564-5689-abe1-a7c7cd007d8c@embeddedor.com>
Date:   Tue, 26 Feb 2019 22:42:11 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Matt Porter <mporter@...nel.crashing.org>,
        Alexandre Bounine <alex.bou9@...il.com>
Cc:     linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] rapidio/mport_cdev: mark expected switch fall-through

Hi all,

Friendly ping:

Who can review or take this, please?

Thanks
--
Gustavo

On 2/12/19 11:50 AM, Gustavo A. R. Silva wrote:
> n preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warning:
> 
> drivers/rapidio/devices/rio_mport_cdev.c: In function ‘mport_release_mapping’:
> drivers/rapidio/devices/rio_mport_cdev.c:2151:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    rio_unmap_inb_region(mport, map->phys_addr);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   CC      drivers/regulator/fixed-helper.o
>   CC      drivers/pinctrl/stm32/pinctrl-stm32f429.o
> drivers/rapidio/devices/rio_mport_cdev.c:2152:2: note: here
>   case MAP_DMA:
>   ^~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/rapidio/devices/rio_mport_cdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
> index cbe467ff1aba..1e1f42e210a0 100644
> --- a/drivers/rapidio/devices/rio_mport_cdev.c
> +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> @@ -2149,6 +2149,7 @@ static void mport_release_mapping(struct kref *ref)
>  	switch (map->dir) {
>  	case MAP_INBOUND:
>  		rio_unmap_inb_region(mport, map->phys_addr);
> +		/* fall through */
>  	case MAP_DMA:
>  		dma_free_coherent(mport->dev.parent, map->size,
>  				  map->virt_addr, map->phys_addr);
>